Skip to content

chore: poc of state / memento pattern#1547

Draft
tj098895 wants to merge 1 commit intomainfrom
friend_of_the_state
Draft

chore: poc of state / memento pattern#1547
tj098895 wants to merge 1 commit intomainfrom
friend_of_the_state

Conversation

@tj098895
Copy link
Copy Markdown
Contributor

@tj098895 tj098895 commented May 7, 2026

Type of Work

  • Patch: X.Y.Z+1. NEGLIGIBLE visible changes, does not change input or output - OR changes behaviour. Use chore:, refactor: etc
  • Minor: X.Y+1.Z. Minor changes, might ADD new input (YAML), or other backwards-compatible changes. Use feat:, fix:
  • Major: X+1.Y.Z. Major and most likely BREAKING changes, wo. backwards compatibility, or removing temporary backwards compatibility functionality. Use ! or BREAKING:.

See here (internal): https://github.com/equinor/ecalc-internal/discussions/1044

Have you remembered and considered?

  • IF FEAT: I have remembered to update documentation
  • IF FIX OR FEAT: I have remembered to update manual changelog (docs/drafts/next.draft.md)
  • IF BREAKING: I have remembered to update migration guide (docs/docs/migration_guides/)
  • IF BREAKING: I have committed with BREAKING: in footer or ! in header
  • I have added tests (if not, comment why)
  • I have used conventional commits syntax (if you squash, make sure that conventional commit is used)
  • I have included the Github issue nr in the footer!

What is this PR all about?

What else did you consider?

Between the lines?


class ProcessUnit(Entity[ProcessUnitId], StreamPropagator, abc.ABC):
@abc.abstractmethod
class ProcessUnit[TSnapshot](Entity[ProcessUnitId], StreamPropagator, abc.ABC):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TSnapshot, or TInput and TOutput? for a snapshot?


class Compressor(ProcessUnit):
@value_object
class OperatingPoint:
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct "input params"?


@value_object
class CompressorSnapshot:
outlet_stream: FluidStream
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant "minimum" output params?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant